Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory pair game #42

Merged
merged 8 commits into from
Aug 15, 2022
Merged

Memory pair game #42

merged 8 commits into from
Aug 15, 2022

Conversation

kovalov
Copy link
Contributor

@kovalov kovalov commented Jul 31, 2022

Memory Pair Game

Demo |
Code base

The code is submitted in a dedicated feature branch.

Only code files are submitted.

Please, review.

@kasionio
Copy link
Contributor

Really great job! Nice style, all works as expected :)
Please make files more mentors-friendly 😄 Indents should be the same across all files in the project. Also better to add some description to the Readme, for example, the rules of the game for people who are not familiar with it. And I am a little bit disappointed not to see some Congrats message at the end of a successful game or even a proposition to start a new one 😞

@kovalov
Copy link
Contributor Author

kovalov commented Aug 2, 2022

Really great job! Nice style, all works as expected :) Please make files more mentors-friendly smile Indents should be the same across all files in the project. Also better to add some description to the Readme, for example, the rules of the game for people who are not familiar with it. And I am a little bit disappointed not to see some Congrats message at the end of a successful game or even a proposition to start a new one disappointed

Have added additional features:

  • start menu with a rules paragraph and play button
  • final screen with number of clicks taken to win

@A-Ostrovnyy A-Ostrovnyy requested a review from kasionio August 3, 2022 16:13
@kasionio
Copy link
Contributor

kasionio commented Aug 5, 2022

Now game engine is broken and it is not working correctly
Screen Shot 2022-08-05 at 10 50 57

😞 Please check

Copy link
Contributor

@kasionio kasionio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try it to make usable from the mobile screens
Screen Shot 2022-08-05 at 11 00 40

@kovalov kovalov requested a review from kasionio August 5, 2022 10:55
@kovalov
Copy link
Contributor Author

kovalov commented Aug 5, 2022

Have fixed issues and added media queries.

Copy link
Contributor

@kasionio kasionio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, now I like it more 👍 Last step left, some code optimization

@kovalov kovalov requested a review from kasionio August 5, 2022 16:50
Copy link
Contributor

@kasionio kasionio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great job 👍

@al0tak al0tak merged commit 6b05ae0 into kottans:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants