Use the more naive crate name to support renaming #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, I suggest merging this an immediately publishing it as version 0.3.8 since the last version breaks a lot of codebases. Some of them will be trivial to fix, but others not. |
|
@diondokter do you think we should yank 0.3.7? |
Urhengulas
approved these changes
May 14, 2024
Probably yes. It is breaking peoples builds, but not all builds. It's not necessarily your fault, but only your yank will fix it sadly |
|
@diondokter I've released defmt-macros v0.3.9 and yanked v0.3.8. Can you test if that un-breaks the builds? |
|
@Urhengulas seems to compile on my end! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #834
::defmtpoints to the crate calleddefmt. This is nice to use because it avoids bad renames. One example I saw wasuse mini_serde as serde.However, people have started renaming the crate in their own crates. Notably, embedded-hal does this which renames it
defmt-03.With the inclusion of defmt in these kinds of foundational crates, they will want to be able to support multiple defmt versions at the same time and they kinda need the renaming. (I don't see another way to do it)
Previously before #800 this all worked, but this PR changed it from
defmtto::defmtwhich breaks code. (And defmt released this as a minor update, so everyone who doescargo updatewill get this).This PR simply reverts that.
Also note that
::defmtisn't even used everywhere. It was a mix. With this PR it's all the same (as far as I can see).