Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trait bounds issue #799 #800

Merged
merged 6 commits into from
Mar 6, 2024
Merged

Fix trait bounds issue #799 #800

merged 6 commits into from
Mar 6, 2024

Conversation

Sympatron
Copy link
Contributor

I gave #799 a try. This is what I came up with. The new tests in defmt/tests/derive-bounds.rs compile now.

@BriocheBerlin
Copy link
Contributor

Thank you! We'll get back to you after the holiday break.

@Urhengulas Urhengulas self-requested a review January 29, 2024 15:39
Urhengulas
Urhengulas requested changes Jan 29, 2024
View reviewed changes
macros/src/derives/format/codegen.rs Outdated Show resolved Hide resolved
macros/src/derives/format/codegen/enum_data.rs Outdated Show resolved Hide resolved
Urhengulas
Urhengulas requested changes Jan 30, 2024
View reviewed changes
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I ran the new test through cargo expand1 before and after the change and the changed expansion looks sensible (see the screenshots below). Just a few nits and then we can merge imo.

baz
quux

Footnotes

  1. cargo expand --features unstable-test --test "derive-bounds" ↩

macros/src/derives/format/codegen/fields.rs Outdated Show resolved Hide resolved
macros/src/derives/format/codegen/fields.rs Show resolved Hide resolved
defmt/tests/ui.rs Show resolved Hide resolved
@Urhengulas
Copy link
Member

@Sympatron hey hey, do you have capacity to work on this?

@Sympatron
Copy link
Contributor Author

@Urhengulas Sorry, somehow didn't see the notifications about your comments. Everything should be fine now.

Urhengulas
Urhengulas requested changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Urhengulas Urhengulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have some small changes I will take care of and then merge it.

macros/src/derives/format/codegen/enum_data.rs Outdated Show resolved Hide resolved
defmt/tests/ui.rs Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
macros/src/derives/format/codegen/fields.rs Outdated Show resolved Hide resolved
@Urhengulas Urhengulas added this pull request to the merge queue Mar 6, 2024
Merged via the queue into knurling-rs:main with commit 8d488c4 Mar 6, 2024
14 checks passed
@diondokter diondokter mentioned this pull request May 13, 2024
Merged
@Sympatron Sympatron mentioned this pull request Aug 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urhengulas Urhengulas Urhengulas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sympatron @BriocheBerlin @Urhengulas