Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added reconciler test runner for Loom receiver and dispatcher images #169

Merged
merged 3 commits into from
Aug 25, 2023

Conversation

debasishbsws
Copy link
Member

It need knative-extensions/eventing-kafka-broker#3292 to be merged before merging.

This is the Reconciler Test for Loom modules.

@knative-prow
Copy link

knative-prow bot commented Aug 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2023
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 19, 2023
@debasishbsws
Copy link
Member Author

/cc @matzew @pierDipi

@knative-prow knative-prow bot requested review from matzew and pierDipi August 19, 2023 19:25
Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
@knative-prow knative-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 24, 2023
@debasishbsws debasishbsws marked this pull request as ready for review August 24, 2023 19:20
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2023
@knative-prow knative-prow bot requested review from cardil and upodroid August 24, 2023 19:20
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debasishbsws, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2023
@knative-prow knative-prow bot merged commit 088a371 into knative:main Aug 25, 2023
12 checks passed
@knative-prow
Copy link

knative-prow bot commented Aug 25, 2023

@debasishbsws: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key eventing-kafka-broker-main.gen.yaml using file prow/jobs/generated/knative-extensions/eventing-kafka-broker-main.gen.yaml

In response to this:

It need knative-extensions/eventing-kafka-broker#3292 to be merged before merging.

This is the Reconciler Test for Loom modules.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants