Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup script for e2e reconciler test #3292

Closed
wants to merge 3 commits into from
Closed

Setup script for e2e reconciler test #3292

wants to merge 3 commits into from

Conversation

debasishbsws
Copy link
Member

@debasishbsws debasishbsws commented Aug 19, 2023 •
edited
Loading

Added blank .sh file for ReconcilerTest with the Loom module images for Receiver and Dispatcher

@debasishbsws
empty-script that pass every time
13aacd3 
Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
@debasishbsws
licence
92fb793 
Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
@debasishbsws
add space
8a8e95c 
Signed-off-by: debasishbsws <debasishbsws.dev@gmail.com>
@knative-prow
Copy link

knative-prow bot commented Aug 19, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023 •
edited
Loading

Codecov Report

Merging #3292 (8a8e95c) into main (c402ae9) will increase coverage by 0.04%.
Report is 10 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #3292      +/-   ##
============================================
+ Coverage     61.78%   61.82%   +0.04%     
- Complexity      764      766       +2     
============================================
  Files           181      181              
  Lines         12220    12220              
  Branches        266      266              
============================================
+ Hits           7550     7555       +5     
+ Misses         4081     4078       -3     
+ Partials        589      587       -2
Flag Coverage Δ
java-unittests 71.67% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@debasishbsws debasishbsws mentioned this pull request Aug 19, 2023
Merged
@debasishbsws debasishbsws marked this pull request as ready for review August 19, 2023 19:26
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 19, 2023
@debasishbsws
Copy link
Member Author

/cc @pierDipi @matzew

@knative-prow knative-prow bot requested review from matzew and pierDipi August 19, 2023 19:26
@pierDipi
Copy link
Member

/test channel-integration-tests-ssl

pierDipi
pierDipi approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 21, 2023
@knative-prow
Copy link

knative-prow bot commented Aug 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debasishbsws, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2023
@pierDipi
Copy link
Member

/test channel-integration-tests-ssl

@debasishbsws
Copy link
Member Author

debasishbsws commented Aug 21, 2023 •
edited
Loading

/hold
We may not need to create new test we might use already created one.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 21, 2023
@debasishbsws
Copy link
Member Author

As currently we are using Env variable to specify to use loom module. We should not need a new test script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierDipi pierDipi pierDipi approved these changes

@creydr creydr Awaiting requested review from creydr

@odacremolbap odacremolbap Awaiting requested review from odacremolbap

@matzew matzew Awaiting requested review from matzew

Assignees

@pierDipi pierDipi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@debasishbsws @pierDipi