Skip to content

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Nov 24, 2025

add e2e reports back so it can be collected via codecov while taking the new FUNC_E2E* variable into consideration
(see comment below for more info)

@knative-prow
Copy link

knative-prow bot commented Nov 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025
@knative-prow
Copy link

knative-prow bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2025
@gauron99 gauron99 marked this pull request as ready for review November 24, 2025 10:47
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.52%. Comparing base (fc761ce) to head (c61155f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3239      +/-   ##
==========================================
+ Coverage   51.80%   54.52%   +2.71%     
==========================================
  Files         162      162              
  Lines       19132    19132              
==========================================
+ Hits         9912    10432     +520     
+ Misses       8242     7661     -581     
- Partials      978     1039      +61     
Flag Coverage Δ
e2e 39.71% <ø> (?)
e2e go 35.69% <ø> (?)
e2e node 31.02% <ø> (?)
e2e python 35.34% <ø> (?)
e2e quarkus 31.18% <ø> (?)
e2e springboot 30.67% <ø> (?)
e2e typescript 31.14% <ø> (?)
integration 17.90% <ø> (+0.02%) ⬆️
unit macos-14 44.38% <ø> (ø)
unit macos-latest 44.38% <ø> (ø)
unit ubuntu-24.04-arm 44.57% <ø> (ø)
unit ubuntu-latest 45.32% <ø> (ø)
unit windows-latest 44.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99
Copy link
Contributor Author

gauron99 commented Nov 24, 2025

This PR should fix recent codecov failures reporting about 7% drops (because less files are being reported) I noticed here for example: #3220
This issue has been introduced in the e2e refactor here #2938
The main CI has had some failures therefore the codecov can pick later main CI to compare to, its comparing to older coverages therefore these issues occur. I dont know why some PRs pick older ones while others dont. Weve had multiple (simple) PRs updating random stuff AFTER the e2e merge but this codecov failure has appeared only now

@matejvasek
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@knative-prow knative-prow bot merged commit 864a37a into knative:main Nov 24, 2025
61 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants