Skip to content

Conversation

@creydr
Copy link
Member

@creydr creydr commented Nov 21, 2025

Changes

Currently the image field in func describe is not set:

{
  "Route": "http://func-go-hello-world.default.svc",
  "routes": [
    "http://func-go-hello-world.default.svc"
  ],
  "name": "func-go-hello-world",
  "image": "",
  "namespace": "default",
  "deployer": "raw",
  "subscriptions": null,
  "labels": {
    "boson.dev/function": "true",
    "function.knative.dev/name": "func-go-hello-world",
    "function.knative.dev/runtime": "go"
  }
}

This PR addressed it and populates the field:

{
  "Route": "http://func-go-hello-world.default.svc",
  "routes": [
    "http://func-go-hello-world.default.svc"
  ],
  "name": "func-go-hello-world",
  "image": "localhost:5001/func-go-hello-world@sha256:805b29c3ff6a379ebab4ddc27e974734d2e23baee3454c38abea9fccfc9b061c",
  "namespace": "default",
  "deployer": "raw",
  "subscriptions": null,
  "labels": {
    "boson.dev/function": "true",
    "function.knative.dev/name": "func-go-hello-world",
    "function.knative.dev/runtime": "go"
  }
}

/kind bug

Release Note

fix: populate image field in func describe

@knative-prow knative-prow bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 21, 2025
@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2025
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.52%. Comparing base (5a1bb65) to head (e38bc53).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
pkg/knative/describer.go 42.10% 8 Missing and 3 partials ⚠️
pkg/k8s/describer.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3220      +/-   ##
==========================================
- Coverage   58.19%   54.52%   -3.68%     
==========================================
  Files         162      162              
  Lines       14763    19158    +4395     
==========================================
+ Hits         8592    10445    +1853     
- Misses       5177     7671    +2494     
- Partials      994     1042      +48     
Flag Coverage Δ
e2e 39.72% <42.10%> (?)
e2e go 35.62% <0.00%> (?)
e2e node 30.98% <0.00%> (?)
e2e python 35.28% <0.00%> (?)
e2e quarkus 31.13% <0.00%> (?)
e2e rust 30.60% <0.00%> (?)
e2e springboot 30.63% <0.00%> (?)
e2e typescript 31.10% <0.00%> (?)
e2e-tests ?
integration 17.96% <68.42%> (?)
integration-tests ?
unit macos-14 44.32% <0.00%> (?)
unit macos-latest 44.32% <0.00%> (?)
unit ubuntu-24.04-arm 44.51% <0.00%> (?)
unit ubuntu-latest 45.26% <0.00%> (?)
unit windows-latest 44.34% <0.00%> (?)
unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@creydr
Copy link
Member Author

creydr commented Nov 21, 2025

/cc @matejvasek @gauron99 @lkingland

@gauron99
Copy link
Contributor

/test all

@gauron99 gauron99 closed this Nov 24, 2025
@gauron99 gauron99 reopened this Nov 24, 2025
@gauron99
Copy link
Contributor

close&reopen to rerun the GH actions. Hopefully the codecov will refresh as well

@gauron99
Copy link
Contributor

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2025
@gauron99
Copy link
Contributor

/approve

@knative-prow
Copy link

knative-prow bot commented Nov 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2025
@knative-prow knative-prow bot merged commit b805b54 into knative:main Nov 24, 2025
79 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants