Skip to content

Generate test certs dynamically#9009

Merged
knative-prow[bot] merged 1 commit intoknative:mainfrom
creydr:gen-certs-keys-for-tests
Apr 2, 2026
Merged

Generate test certs dynamically#9009
knative-prow[bot] merged 1 commit intoknative:mainfrom
creydr:gen-certs-keys-for-tests

Conversation

@creydr
Copy link
Copy Markdown
Member

@creydr creydr commented Apr 2, 2026

Generate test certs dynamically instead of hardcoding them

Same as knative-extensions/eventing-kafka-broker#4678 but for eventing-core

@creydr creydr requested review from Cali0707 and twoGiants April 2, 2026 09:28
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Apr 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from Leo6Leo and aliok April 2, 2026 09:28
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

❌ Patch coverage is 0% with 83 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.02%. Comparing base (c6be563) to head (ccd19ea).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...entingtls/eventingtlstesting/eventingtlstesting.go 0.00% 83 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9009   +/-   ##
=======================================
  Coverage   51.02%   51.02%           
=======================================
  Files         409      409           
  Lines       22001    21996    -5     
=======================================
- Hits        11225    11223    -2     
+ Misses       9914     9910    -4     
- Partials      862      863    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@creydr
Copy link
Copy Markdown
Member Author

creydr commented Apr 2, 2026

/test reconciler-tests

@creydr
Copy link
Copy Markdown
Member Author

creydr commented Apr 2, 2026

/cc @maschmid

@knative-prow knative-prow bot requested a review from maschmid April 2, 2026 12:50
@maschmid
Copy link
Copy Markdown
Contributor

maschmid commented Apr 2, 2026

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2026
@knative-prow knative-prow bot merged commit 263a3a5 into knative:main Apr 2, 2026
37 checks passed
@dprotaso
Copy link
Copy Markdown
Member

dprotaso commented Apr 2, 2026

/cherry-pick release-1.21
/cherry-pick release-1.20

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@dprotaso: new pull request created: #9011

Details

In response to this:

/cherry-pick release-1.21
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Copy Markdown
Contributor

@dprotaso: new pull request created: #9012

Details

In response to this:

/cherry-pick release-1.21
/cherry-pick release-1.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants