Skip to content

regenerate expired hardcoded certs#8986

Closed
maschmid wants to merge 1 commit intoknative:mainfrom
maschmid:maschmid-main-regenerate-certificates
Closed

regenerate expired hardcoded certs#8986
maschmid wants to merge 1 commit intoknative:mainfrom
maschmid:maschmid-main-regenerate-certificates

Conversation

@maschmid
Copy link
Copy Markdown
Contributor

Unit tests are now failing because of the expired hardoced test certs

Proposed Changes

  • 🧹 Update hardcoded unit test certificates

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 31, 2026
@knative-prow knative-prow bot requested review from aliok and matzew March 31, 2026 14:46
@knative-prow
Copy link
Copy Markdown

knative-prow bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maschmid
Once this PR has been reviewed and has the lgtm label, please assign matzew for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

❌ Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.03%. Comparing base (c6be563) to head (9a6e613).

Files with missing lines Patch % Lines
...entingtls/eventingtlstesting/eventingtlstesting.go 0.00% 58 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8986      +/-   ##
==========================================
+ Coverage   51.02%   51.03%   +0.01%     
==========================================
  Files         409      409              
  Lines       22001    22001              
==========================================
+ Hits        11225    11228       +3     
+ Misses       9914     9910       -4     
- Partials      862      863       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@maschmid maschmid closed this Apr 2, 2026
@maschmid
Copy link
Copy Markdown
Contributor Author

maschmid commented Apr 2, 2026

closing, as #9009 is obviously better :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant