Update dependencies #2101
Merged
Update dependencies #2101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumping github.com/modern-go/reflect2 2b33151...35a7c28: > 35a7c28 Merge pull request # 30 from tonistiigi/deadcode-fix > 4a6a3c9 fix deadcode disabling in Go bumping knative.dev/networking 4115314...7d4a198: > 7d4a198 Update community files (# 1098) > 6a680e8 upgrade to latest dependencies (# 1096) bumping github.com/spf13/cobra e94f6d0...40b5bc1: > 40b5bc1 Revert "Make detection for test-binary more universal (# 2173)" (# 2235) > a97f9fd fix CompletionFunc implementation (# 2234) > 5f9c408 chore: Upgrade dependencies for v1.9.0 (# 2233) > 24ada7f Remove the default "completion" cmd if it is alone (# 1559) > 680936a New logo > 8cb30f9 feat: add CompletionWithDesc helper (# 2231) > 17b6dca doc: add Conduit (# 2230) > ab5cadc Allow to reset the templates to the default (# 2229) > 4ba5566 fix(bash): nounset unbound file filter variable on empty extension (# 2228) > 41b26ec Print ActiveHelp for bash along other completions (# 2076) > 611e16c Allow linker to perform deadcode elimination for program using Cobra (# 1956) > 09d5664 Add similar whitespace escape logic to bash v2 completions than in other completions (# 1743) > 6c3c116 feat: add CompletionFunc type to help with completions (# 2220) > 01ffff4 chore: fix function name in comment (# 2216) > 0745e55 completion: improve detection for flags that accept multiple values (# 2210) > d1e9d85 Make detection for test-binary more universal (# 2173) > 9f90567 build(deps): bump github.com/cpuguy83/go-md2man/v2 from 2.0.5 to 2.0.6 (# 2206) > 8519630 Update to latest go-md2man (# 2201) > 02326d5 Fix broken links in active_help.md (# 2202) > 5a138f1 Make Powershell completion script work in constrained mode (# 2196) > 3a5efae doc: azion project added to the list of CLIs that use cobra (# 2198) > 5bef9d8 Fix --version help and output for plugins (# 2180) > ff7c561 Improve site formatting (# 2183) > 11ab621 docs: update README.md (# 2197) > 78bfc83 Test also with go 1.23 (# 2182) > 511af59 Replace deprecated ioutil usage (# 2181) > 756ba6d fix(completions): Complete map flags multiple times (# 2174) > 371ae25 Fix deprecation comment for Command.SetOutput (# 2172) bumping knative.dev/serving 2f3129a...cd99679: > cd99679 Update net-istio nightly (# 16228) > 8cf543d Update net-contour nightly (# 16229) > 78814e1 Update net-istio nightly (# 16224) > 5f7aa6e Update net-istio nightly (# 16221) > 41fafd1 Update net-contour nightly (# 16214) > 7c31784 Allow manual scaling of the Pod Autoscaler (# 16186) > 7283f2a Suppress 'default value insecure' warning (# 16218) > 433d1ee Update net-gateway-api nightly (# 16213) > 7ceeaea Update net-kourier nightly (# 16212) > 8e762fd Update net-istio nightly (# 16211) > 029c5be Update community files (# 16210) > 3d3acd2 Bump the github-actions group with 3 updates (# 16207) Signed-off-by: Knative Automation <automation@knative.team>
Two test failures were introduced by the dependency upgrade: 1. pkg/serving/v1/client_test.go:697 - Fixed incorrect use of restrictions.Labels.Matches() instead of restrictions.Fields.Matches(). The newer version of k8s.io/apimachinery added a Lookup method to the labels.Labels interface that fields.Set doesn't implement, causing a compile error that exposed this existing bug. 2. pkg/util/unstructured_test.go - Updated test expectations to match new JSON marshaling behavior. The newer k8s libraries no longer include "creationTimestamp: nil" fields when marshaling objects with zero/nil timestamps.
This is required since some dependencies would now use conflicting versions of the genproto dependency.
knative-prow
bot
added
approved
Contributor
Author
|
/remove-approve |
knative-prow
bot
removed
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
=======================================
Coverage 71.88% 71.88%
=======================================
Files 233 233
Lines 13533 13533
=======================================
Hits 9728 9728
Misses 2999 2999
Partials 806 806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
Contributor
Author
|
/cc @dsimansk As discussed in slack 😄 |
This was referenced Nov 18, 2025
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2100 which is always force pushed by knobot 😢
Also updates other deps that are currently causing issues in some plugin repositories due to conflicts, check the commits for more details.