Skip to content

Conversation

@dprotaso
Copy link
Contributor

No description provided.

@knative-prow
Copy link

knative-prow bot commented Nov 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.30%. Comparing base (852a107) to head (d7f515c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #434   +/-   ##
=======================================
  Coverage   22.30%   22.30%           
=======================================
  Files          32       32           
  Lines        1955     1955           
=======================================
  Hits          436      436           
  Misses       1484     1484           
  Partials       35       35           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knative-prow knative-prow bot requested a review from dsimansk November 19, 2025 08:15
@dprotaso
Copy link
Contributor Author

/assign @dsimansk @linkvt

this unblocks knobots

@linkvt
Copy link
Contributor

linkvt commented Nov 19, 2025

LGTM in general but there is also knative/client#2101 - I thought that that PR would also unblock stuff here?

@linkvt
Copy link
Contributor

linkvt commented Nov 19, 2025

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2025
@knative-prow knative-prow bot merged commit ce188ec into knative-extensions:main Nov 19, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants