Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modexp precompile 384 bits #1513

Merged
merged 20 commits into from
Nov 12, 2024
Merged

feat: modexp precompile 384 bits #1513

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
59f12ef
🔥 remove old version
tekkac Oct 19, 2024
8a01b32
🧪 add test data visibility
tekkac Oct 19, 2024
be550c5
✨ circuit implementation of modexp + test cases
tekkac Oct 19, 2024
d13f960
🩹 fix edge case + comments
tekkac Oct 23, 2024
834f946
🧪 fix test and remove unused imports
tekkac Oct 23, 2024
cc637f4
🔥 remove unused tests
tekkac Oct 30, 2024
c2d1e0d
Merge branch 'main' into feat/modexp-precompile-384-bits
tekkac Oct 30, 2024
dbe8a12
run modexp ef-tests
enitrat Nov 6, 2024
d66f8bb
minor changes
enitrat Nov 6, 2024
2aad400
restore failing tests in skipfile
enitrat Nov 6, 2024
c60f4fa
early return on invalid input len
enitrat Nov 6, 2024
a743f51
📝 add test explanation
tekkac Nov 6, 2024
e28a318
✏️ fix test_data input
tekkac Nov 6, 2024
59d0649
skip failing ef tests due to big input sizes
enitrat Nov 7, 2024
3ee0e8c
add generated test data against EELS
enitrat Nov 7, 2024
f3f4002
make execution fail is input is invalid instead of empty output
enitrat Nov 7, 2024
6e33faa
📝 more explicit doc and naming
tekkac Nov 7, 2024
3567c15
Merge branch 'main' into feat/modexp-precompile-384-bits
tekkac Nov 8, 2024
f13ffe9
skip random test failing
enitrat Nov 9, 2024
4572dc5
Merge branch 'main' into feat/modexp-precompile-384-bits
ClementWalter Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 18 additions & 40 deletions cairo/kakarot-ssj/blockchain-tests-skip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,8 @@ testname:
- CallEcrecover_Overflow_d4g0v0_Cancun
- CallEcrecover_Overflow_d5g0v0_Cancun
- CallRipemd160_5_d0g0v0_Cancun
- modexpRandomInput_d0g0v0_Cancun
- modexpRandomInput_d0g1v0_Cancun
stPreCompiledContracts:
- idPrecomps_d2g0v0_Cancun
- idPrecomps_d7g0v0_Cancun
Expand Down Expand Up @@ -333,46 +335,6 @@ testname:
- precompsEIP2929Cancun_d81g0v0_Cancun
- precompsEIP2929Cancun_d92g0v0_Cancun
- precompsEIP2929Cancun_d99g0v0_Cancun
- modexp_d11g0v0_Cancun
- modexp_d11g1v0_Cancun
- modexp_d11g2v0_Cancun
- modexp_d11g3v0_Cancun
- modexp_d14g0v0_Cancun
- modexp_d14g1v0_Cancun
- modexp_d14g2v0_Cancun
- modexp_d14g3v0_Cancun
- modexp_d16g0v0_Cancun
- modexp_d16g1v0_Cancun
- modexp_d16g2v0_Cancun
- modexp_d16g3v0_Cancun
- modexp_d17g0v0_Cancun
- modexp_d17g1v0_Cancun
- modexp_d17g2v0_Cancun
- modexp_d17g3v0_Cancun
- modexp_d25g0v0_Cancun
- modexp_d25g1v0_Cancun
- modexp_d25g2v0_Cancun
- modexp_d25g3v0_Cancun
- modexp_d26g0v0_Cancun
- modexp_d26g1v0_Cancun
- modexp_d26g2v0_Cancun
- modexp_d26g3v0_Cancun
- modexp_d27g0v0_Cancun
- modexp_d27g1v0_Cancun
- modexp_d27g2v0_Cancun
- modexp_d27g3v0_Cancun
- modexp_d29g0v0_Cancun
- modexp_d29g1v0_Cancun
- modexp_d29g2v0_Cancun
- modexp_d29g3v0_Cancun
- modexp_d30g0v0_Cancun
- modexp_d30g1v0_Cancun
- modexp_d30g2v0_Cancun
- modexp_d30g3v0_Cancun
- modexp_d33g0v0_Cancun
- modexp_d33g1v0_Cancun
- modexp_d33g2v0_Cancun
- modexp_d33g3v0_Cancun
- precompsEIP2929Cancun_d10g0v0_Cancun
- precompsEIP2929Cancun_d115g0v0_Cancun
- precompsEIP2929Cancun_d133g0v0_Cancun
Expand All @@ -385,6 +347,18 @@ testname:
- precompsEIP2929Cancun_d313g0v0_Cancun
- precompsEIP2929Cancun_d79g0v0_Cancun
- precompsEIP2929Cancun_d97g0v0_Cancun
- modexp_d27g0v0_Cancun
- modexp_d27g1v0_Cancun
- modexp_d27g2v0_Cancun
- modexp_d27g3v0_Cancun
- modexp_d29g0v0_Cancun
- modexp_d29g1v0_Cancun
- modexp_d29g2v0_Cancun
- modexp_d29g3v0_Cancun
- modexp_d30g0v0_Cancun
- modexp_d30g1v0_Cancun
- modexp_d30g2v0_Cancun
- modexp_d30g3v0_Cancun
stQuadraticComplexityTest:
- Call20KbytesContract50_1_d0g0v0_Cancun
- Call20KbytesContract50_2_d0g0v0_Cancun
Expand Down Expand Up @@ -476,6 +450,10 @@ testname:
- revertRetDataSize_d7g0v0_Cancun
- revertRetDataSize_d8g0v0_Cancun
- revertRetDataSize_d9g0v0_Cancun
# Next three tests are skipped because the input size is > 48 bits
- modexp_modsize0_returndatasize_d2g0v0_Cancun
- modexp_modsize0_returndatasize_d3g0v0_Cancun
- modexp_modsize0_returndatasize_d4g0v0_Cancun
stRevertTest:
- LoopCallsDepthThenRevert2_d0g0v0_Cancun
- LoopCallsDepthThenRevert3_d0g0v0_Cancun
Expand Down
Loading
Loading