-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modexp precompile 384 bits #1513
feat: modexp precompile 384 bits #1513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great :)
Why are ef-tests failing? |
passing now after updating branch |
thanks, will do a second pass soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect now 💯
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1513 +/- ##
=======================================
- Coverage 63.6% 63.5% -0.1%
=======================================
Files 44 44
Lines 8332 8332
=======================================
- Hits 5301 5298 -3
- Misses 3031 3034 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can do a follow up PR, but in a second thought we said that we could move these tests to end to end to make direct call to the precompile, instead of unit with generated data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with merging as is if it's all ✅ and do follow up PRs for
- possible improvements cc @feltroidprime
- refactoring tests to end-to-end directly cc @enitrat
Time spent on this PR:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Resolves #1496
What is the new behavior?
This change is