Skip to content

Updated our bindings to support Android's 16KB page size. #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kelson42 merged 2 commits into from
Oct 29, 2025
+7 −4
Merged

Updated our bindings to support Android's 16KB page size. #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5846e0c
Upgraded the ndkVersion to `23.2.8568313` to support new libkiwix, an…
MohitMaliDeveloper Oct 24, 2025
5c10ffc
Upgrading to this NDK version because older NDKs compile `libc++_shar…
MohitMaliDeveloper Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ android {
externalNativeBuild {
cmake {
cppFlags '-g'
arguments "-DANDROID_STL=c++_shared", "-DBUILD_DIR=${buildDir}", "-DANDROID_DEBUG_SYMBOLS=ON"
arguments "-DANDROID_STL=c++_shared", "-DBUILD_DIR=${buildDir}", "-DANDROID_DEBUG_SYMBOLS=ON", "-DANDROID_SUPPORT_FLEXIBLE_PAGE_SIZES=ON"
}
}
}
Expand Down Expand Up @@ -79,13 +79,16 @@ android {
externalNativeBuild {
cmake {
path file('src/main/cpp/CMakeLists.txt')
version '3.18.1'
version '3.22.1'
}
}
buildFeatures {
viewBinding true
}
ndkVersion '21.4.7075529'
// Upgrading to this NDK version because older NDKs compile `libc++_shared.so`
// with a 4 KB page size. Starting with NDK r27, it is built with a 16 KB page size by default.
// This resolves compatibility issues reported by the Play Store. See #119 for details.
ndkVersion '27.3.13750724'

// Enabled the lint to avoid potential errors.
lintOptions {
Expand Down
2 changes: 1 addition & 1 deletion lib/src/main/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@

set(CMAKE_FIND_ROOT_PATH_MODE_LIBRARY BOTH)
cmake_minimum_required(VERSION 3.18.1)
cmake_minimum_required(VERSION 3.22.1)

project("libkiwix_wrapper")

Expand Down