Updated our bindings to support Android's 16KB page size. #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=========================================
Coverage 93.23% 93.23%
Complexity 237 237
=========================================
Files 47 47
Lines 325 325
Branches 3 3
=========================================
Hits 303 303
Misses 19 19
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kelson42
approved these changes
Oct 26, 2025
Contributor
kelson42
left a comment
kelson42
left a comment
There was a problem hiding this comment.
LGTM, putting @veloman-yunkan as second reviewer
Contributor
|
@MohitMaliDeveloper Can you please rebase and fix conflict so we can merge? |
…d libzim as they are now using r23c. * Upgraded the cmake version to `3.22.1` to work with new NDK, as after upgrading the NDK previous version of cmake was deprecated for this new NDK version.
…ed.so` with a 4 KB page size. Starting with NDK r27, it is built with a 16 KB page size by default.
MohitMaliFtechiz
force-pushed
the
Fixes#119
branch
from
cf3b8ec to
5c10ffc
Compare
Collaborator
Author
|
@kelson42 resolved the conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
22.04.27.3.13750724because older NDKs compilelibc++_shared.sowith a 4 KB page size. Starting with NDK r27, it is built with a 16 KB page size by default. In older NDK versions, some files were generated with a 4KB page size, which is included in thec++_shared.sofile. So using those versions still gives the warning that our library not compiled with a 16KB page size.3.22.1to work with the new NDK, as after upgrading the NDK previous version of CMake was deprecated for this new NDK version.