This repository was archived by the owner on Apr 11, 2020. It is now read-only.
Run LO in the same process #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like it works. Will prettify if this is good enough solution for now |
…cess" param. The change will allow templateddoc to be ran in celery without causing the following error: "daemonic processes are not allowed to have children"
kiawin
force-pushed
the
run-lokit-in-same-process
branch
from
980f11e to
e444ceb
Compare
kiawin
force-pushed
the
run-lokit-in-same-process
branch
from
d0ca7ae to
8732789
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Current code will not run in celery due to
AssertionError: daemonic processes are not allowed to have childrenSolution:
This isn't a proper solution, just wanted a snippet we can use to discuss.
See these to understand context on why
Processwas used:Processwas used to prevent django from crashing on LO errors. I made it run in the same process.Threadhere is not needed, just wanted to change least amount of code to get it running on our beta server.Along with this PR, version is bumped to
0.3.3and support for Django1.11.xis added.