Skip to content

Use billiard instead of multiprocessing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2020
Merged

Conversation

willycahyadi
Copy link

Problem
Multiprocessing lib is causing this library to be unusable in celery
environment, due to celery worker daemon process can't spawn another
child.
While spawning another child is important, because opening
pylokit.Office more than once can cause system exit 77 / 139.

Solution
Replace multiprocessing with billiard since billiard is supported to run on celery and will still run outside of celery worker.

Reference
kiawin#3

Multiprocessing lib is causing this library to be unusable in celery
environment, due to celery worker daemon process can't spawn another
child.
While spawning another child is important, because opening
pylokit.Office more than once can cause system exit 77 / 139.
Replacing multiprocessing with billiard enables this library to run in
celery environment.
@willycahyadi willycahyadi requested a review from Jafnee May 29, 2020 06:22
@willycahyadi willycahyadi self-assigned this May 29, 2020
@willycahyadi willycahyadi merged commit 00181da into master May 29, 2020
@willycahyadi willycahyadi deleted the use-billiard branch May 29, 2020 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants