Always use POSIX path separator when printing types #8439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
borisno2
force-pushed
the
always-print-posix
branch
2 times, most recently
from
2f7196d to
2c54760
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7afa523:
|
dcousens
reviewed
Mar 29, 2023
borisno2
force-pushed
the
always-print-posix
branch
from
e43f6d0 to
7afa523
Compare
borisno2
changed the title
/) in Types Printer
borisno2
changed the title
/) in Types Printer
dcousens
approved these changes
Mar 30, 2023
dcousens
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8381 added the ability to set an output path for Keystone types to be generated.
The generated types printed a relative path to the Prisma client when a
prismaClientPathis provided.On Windows, this would use
\\as the path separator, compared to/on POSIX operating systems.Windows is interoperable with either. Using
\\resulted in unreadable path strings for Windows users.This pull request changes the behaviour to always use a POSIX path separator (
/), ensuring if types are committed to source control they are readable on both platforms, without any change in behaviour.