Add new types.path property
#8381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
dcousens
changed the title
types.listTypesPath propertytypes.listTypesPath property
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 23b987f:
|
jlarmstrongiv
suggested changes
Mar 9, 2023
There was a problem hiding this comment.
Looking good 😄 can’t wait to give keystone with monorepos another try. Between this PR and #8307, it should be more doable now
dcousens
commented
Mar 14, 2023
dcousens
force-pushed
the
types-where
branch
4 times, most recently
from
9fc5ff4 to
e34301d
Compare
borisno2
approved these changes
Mar 14, 2023
borisno2
reviewed
Mar 14, 2023
borisno2
reviewed
Mar 14, 2023
borisno2
reviewed
Mar 14, 2023
borisno2
reviewed
Mar 14, 2023
dcousens
changed the title
types.listTypesPath propertytypes.path property
dcousens
force-pushed
the
types-where
branch
6 times, most recently
from
842ff98 to
a3185f6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
.types.pathconfiguration option that will enable developers to specify where their Keystone types are built.Previously you imported your types with
.keystone/types, which are automatically built innode_modules/.keystone/types.d.ts. This is suitable for many usecases, but if you're using a monorepo, you might want to import these types in your other workspaces. Usingnode_modules/.keystone/...prevented that.You can now specify a
.types.paththat works for you.If you were relying on
.keystone/types, that will break only if you use this feature.Thereby, this is not a breaking change.
We thought about opting to try and keep
.keystone/typesresolving, even with a customtypes.path, but that actually ended up in a number of weird edge-cases that aren't easy to debug.