Skip to content

fix: don't show colons on android #23786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2020
Merged

fix: don't show colons on android #23786

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
243077a
fix: don't show colons on android
Apr 15, 2020
02b3f23
fix: add comment with issue
Apr 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions shared/teams/emojis/common.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,9 @@ export class AliasInput extends React.PureComponent<AliasInputProps, {}> {
error={!!this.props.error}
disabled={this.props.disabled}
textType={Styles.isMobile ? 'BodySemibold' : 'Body'}
value={`:${this.props.alias}:`}
// android has issues with setSelection that make including colons a bad experience
// see https://keybase.atlassian.net/browse/TRIAGE-2680
value={Styles.isAndroid ? this.props.alias : `:${this.props.alias}:`}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets add a comment and a ticket

containerStyle={Styles.collapseStyles([
styles.aliasInput,
!this.props.small && styles.aliasInputLarge,
Expand All @@ -52,7 +54,8 @@ export class AliasInput extends React.PureComponent<AliasInputProps, {}> {
this.props.onChangeAlias(newText.replace(/[^a-zA-Z0-9-_+]/g, ''))
}
onEnterKeyDown={this.props.onEnterKeyDown}
onFocus={this.onFocus}
// TODO: remove android exception when https://keybase.atlassian.net/browse/TRIAGE-2680 fixed
onFocus={Styles.isAndroid ? undefined : this.onFocus}
/>
{this.props.onRemove && (
<Kb.ClickableBox onClick={this.props.onRemove} style={styles.removeBox}>
Expand Down