fix: don't show colons on android #23786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisnojima
reviewed
Apr 15, 2020
| disabled={this.props.disabled} | ||
| textType={Styles.isMobile ? 'BodySemibold' : 'Body'} | ||
| value={`:${this.props.alias}:`} | ||
| value={Styles.isAndroid ? this.props.alias : `:${this.props.alias}:`} |
There was a problem hiding this comment.
lets add a comment and a ticket
chrisnojima
approved these changes
Apr 15, 2020
|
also we should likely pr against master and pick instead of having this just in the hotfix |
cori-hudson
force-pushed
the
cori/android-emoji-input-fix
branch
from
af66b02 to
243077a
Compare
cori-hudson
added a commit
that referenced
this pull request
Apr 15, 2020
* fix: don't show colons on android * fix: add comment with issue
jryio
pushed a commit
that referenced
this pull request
Apr 22, 2020
* fix: don't show colons on android * fix: add comment with issue
jryio
pushed a commit
that referenced
this pull request
Apr 22, 2020
* fix: don't show colons on android * fix: add comment with issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.