Skip to content

Modify kvm-qemu.sh to apply changes in #1634 back #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Modify kvm-qemu.sh to apply changes in #1634 back #2606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion installer/kvm-qemu.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,7 +778,7 @@ function replace_seabios_clues_public() {

FILES=(
src/hw/blockcmd.c
src/fw/paravirt.c
#src/fw/paravirt.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change comments out src/fw/paravirt.c, preventing the replacement of "QEMU" strings within it. While the PR description and title reference issues #2588 and #1634, it would be beneficial for long-term maintainability to include a brief inline comment here.

Could you add a comment explaining why this specific file is excluded from the string replacement? This would help future developers understand the reasoning without needing to track down external issue trackers or PRs, especially concerning its impact on VM detection capabilities.

Suggested change
#src/fw/paravirt.c
#src/fw/paravirt.c # Excluded to address issue #2588 (and revert part of #1634)

)
for file in "${FILES[@]}"; do
_sed_aux 's/"QEMU"/"'"$BOCHS_BLOCK_REPLACER2"'"/g' "$file" "QEMU was not replaced in $file"
Expand Down