Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devcontainer #242

Closed
bhack opened this issue Mar 30, 2022 · 9 comments · Fixed by #267
Closed

Devcontainer #242

bhack opened this issue Mar 30, 2022 · 9 comments · Fixed by #267

Comments

@bhack
Copy link
Contributor

bhack commented Mar 30, 2022

Can we have a .devcontainer like in Keras?

https://github.com/keras-team/keras/tree/master/.devcontainer

@LukeWood
Copy link
Contributor

Would this be useful to you personally?

If so, I can't see why not. Happy to do this to support your workflow. As long as we have someone using it and maintain it.

@bhack
Copy link
Contributor Author

bhack commented Mar 31, 2022

Can you double check this with the internally board before I start?

Honestly I had a not so good experience with another PR in this repo:
#11 (comment)
#14 (comment)

@LukeWood
Copy link
Contributor

LukeWood commented Mar 31, 2022

Understandable and still sorry about that. Cheers - I will double check tomorrow for you.

Does .devcontainer impact anyone else's workflow or only those who opt in to using them?

Is it used with VSCode?

@LukeWood
Copy link
Contributor

Hey @bhack yeah happy to accept this. Just checked

@LukeWood
Copy link
Contributor

Lets mirror keras-tuner's, but I don't think we want the linter as a pre-commit hook from what we have generally discussed as a team.

So our setup.sh will just have:

pip install -e ".[tests]"
pip install -e ".[examples]"

Cheers - if anyone wants to pick this up happy to accept

@bhack
Copy link
Contributor Author

bhack commented Apr 4, 2022

Do we want to depend on latest or nightly Tensorflow images?

https://github.com/keras-team/keras-tuner/blob/master/.devcontainer/Dockerfile#L1

See also out thread at:
#195 (comment)

@LukeWood
Copy link
Contributor

LukeWood commented Apr 4, 2022

we can use nightly for now, until the next tensorflow version comes out which will have BaseImageAugmentationLayer in the keras namespace.

@bhack
Copy link
Contributor Author

bhack commented Apr 4, 2022

we can use nightly for now, until the next tensorflow version comes out which will have BaseImageAugmentationLayer in the keras namespace.

Do you have a minimal date for nightly?

@LukeWood
Copy link
Contributor

LukeWood commented Apr 4, 2022

Do you have a minimal date for nightly?

minimal in what sense? A date when we can move to normal tf? I believe this can be done the release after 2.9, so 2.10. after 2.9 lands we can try changing the dependency to tensorflow from tf-nightly and see if it works.

@bhack bhack mentioned this issue Apr 5, 2022
freedomtan pushed a commit to freedomtan/keras-cv that referenced this issue Jul 20, 2023
The _built_from_signature property is no longer used or useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants