Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a tf.version check #195

Closed
LukeWood opened this issue Mar 22, 2022 · 2 comments
Closed

Implement a tf.version check #195

LukeWood opened this issue Mar 22, 2022 · 2 comments

Comments

@LukeWood
Copy link
Contributor

https://github.com/keras-team/keras-tuner/blob/master/keras_tuner/utils.py#L57

We need 2.8.0>

@bhack
Copy link
Contributor

bhack commented Mar 22, 2022

The problem is also that depending only on tf-nightly doesn't enforce anything if we don't define > date
e.g: tf-nightly 2.9.0.dev20220322.

Currently with only tf-nightly will mean that any nightly dependency satisfy keras-cv and so also a pre 2.8.0 or a 2 years old tf-nightly

https://github.com/keras-team/keras-cv/blob/master/setup.py#L35

@LukeWood
Copy link
Contributor Author

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants