-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(startup): posthog issue when enabled and no connectivity #631
Conversation
@vijay-jangir is attempting to deploy a commit to the KeepHQ Team on Vercel. A member of the Team first needs to authorize it. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #631 +/- ##
==========================================
+ Coverage 68.04% 68.07% +0.03%
==========================================
Files 48 45 -3
Lines 2691 2390 -301
==========================================
- Hits 1831 1627 -204
+ Misses 860 763 -97 ☔ View full report in Codecov by Sentry. |
… issue, temporarily fixed it to atleast get the application in started mode. Updated dockerfile for ui and api so that it can run seemlessly on openshift update dockerfile for api for caching layers more efficiently
708ca03
to
0040c15
Compare
Signed-off-by: talboren <talboren2@gmail.com>
@vijay-jangir I've edited the |
Signed-off-by: talboren <talboren2@gmail.com>
@vijay-jangir this now lgtm, lmk once you've had a chance to take a look and I can merge this in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This looks fine, as long as we're okay with posthog still crashing the backend if network is behind a proxy or firewall, incase the POSTHOG_ENABLE is set to true. |
It's now disabled by default, so it won't :) |
Dockerfile enhancement, posthog bugfix
posthog doesn't let application start if there is any connection issue, temporarily fixed it to atleast get the application in started mode.
Updated dockerfile for ui and api so that it can run seemlessly on openshift update dockerfile for api for caching layers more efficiently
Closes #
📑 Description
✅ Checks
ℹ Additional Information