Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: measure amount of running instances #2366

Merged
merged 15 commits into from
Nov 3, 2024

Conversation

Matvey-Kuk
Copy link
Contributor

@Matvey-Kuk Matvey-Kuk commented Oct 31, 2024

  • Reverting fix(startup): posthog issue when enabled and no connectivity #631
  • Not reporting to posthog if there is no connectivity to it.
  • Tested with air-gapped keep.
  • Removing duplicate env var: ENABLE_POSTHOG_API because we have DISABLE_POSTHOG
  • Reporting backend uptime to PostHog every 10 minutes.
  • PostHog is messing up with unnittests causing infinite recursion. Spent a pile of time trying to find the reason, just disabling it for Unittests.

Closes #2367

Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Nov 3, 2024 1:39pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. API API related issues Feature A new feature labels Oct 31, 2024
keep/posthog/posthog.py Outdated Show resolved Hide resolved
Copy link

gitguardian bot commented Oct 31, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8134198 Triggered Generic High Entropy Secret ba20a40 keep-ui/app/frigade-provider.tsx View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments

docs/development/getting-started.mdx Outdated Show resolved Hide resolved
keep-ui/.env.local.example Outdated Show resolved Hide resolved
keep/api/api.py Outdated Show resolved Hide resolved
keep/posthog/posthog.py Outdated Show resolved Hide resolved
keep/posthog/posthog.py Outdated Show resolved Hide resolved
Co-authored-by: Tal <tal@keephq.dev>
Signed-off-by: Matvey Kukuy <Matvey-Kuk@users.noreply.github.com>
Copy link
Member

@talboren talboren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 3, 2024
@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) November 3, 2024 13:55
@Matvey-Kuk Matvey-Kuk merged commit 9583a7b into main Nov 3, 2024
14 checks passed
@Matvey-Kuk Matvey-Kuk deleted the Matvey-Kuk/measure-running-instances branch November 3, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API API related issues Feature A new feature lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[👨🏻‍💻 Internal]: measure amount of running instances
2 participants