Support Deferred Type Annotations in Dataset Previews #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
SajidAlamQB
requested review from
rashidakanchwala,
ravi-kumar-pilla and
jitu5
as code owners
Signed-off-by: Sajid Alam <sajid_alam@mckinsey.com>
|
Reverted FE changes as they didn't have any effect and were causing the failures. |
ravi-kumar-pilla
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to: kedro-org/kedro-plugins#595 and #1622
This PR updates dataset preview types to support deferred type annotations,
from __future__ import annotations.With
from __future__ import annotations, annotations are stored as strings and resolved when needed rather than immediately. This affects how annotations are accessed in Kedro-Viz particularly in how we retrievepreview_typefor datasets.Development notes
set_preview_typein the backend to accommodate type annotations as strings.Checklist
RELEASE.mdfile