-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend 'preview' mechanism to kedro-datasets #1622
Comments
Refer to the spike work done here - #1623 |
One thing that is not clear to me - is the idea to extend the |
I've been trying to understand this issue and have some questions: Can we confirm the scope of this ticket, is there list of dataset types that need the preview functionality extended? Will the implementation follow similar structure done in kedro-org/kedro-plugins#504? |
Extended preview to the following:
|
Description
Ticket SQL is blocked as existing solutions aren't viable.
The most optimal solution would be modifying kedro-datasets to have a new supporting method for kedro-viz, which would shift responsibility from
viz
tokedro-plugins
instead. Easier to test, less coupling between the two systems.Context
A change like this is accepted by multiple team members - it's a viable compromise, but still doable
Possible Implementation
Adding the existing 'preview' method in kedro-datasets to ones like SQLQueryDataset.
The text was updated successfully, but these errors were encountered: