Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove .ipython dir and update readme files #78

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Remove .ipython dir and update readme files #78

merged 1 commit into from
Mar 30, 2022

Conversation

merelcht
Copy link
Member

Signed-off-by: Merel Theisen merel.theisen@quantumblack.com

Motivation and Context

Follow up to: kedro-org/kedro#1355

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@merelcht
Remove .ipython dir + mentions of it + update readmes
4e31daa 
Signed-off-by: Merel Theisen <merel.theisen@quantumblack.com>
@merelcht merelcht self-assigned this Mar 30, 2022
lorenabalan
lorenabalan approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@lorenabalan lorenabalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks for updating instructions on requirements.lock stuff too! 🙏

@lorenabalan lorenabalan mentioned this pull request Mar 30, 2022
Closed
3 tasks
AhdraMeraliQB
AhdraMeraliQB approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@merelcht merelcht merged commit faab0e4 into 0.18.0 Mar 30, 2022
@merelcht merelcht deleted the feat/update-ipython branch March 30, 2022 19:32
@lorenabalan lorenabalan mentioned this pull request Mar 31, 2022
Merged
3 tasks
@idanov idanov mentioned this pull request Jan 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhdraMeraliQB AhdraMeraliQB AhdraMeraliQB approved these changes

@lorenabalan lorenabalan lorenabalan approved these changes

@noklam noklam Awaiting requested review from noklam

Assignees

@merelcht merelcht

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@merelcht @lorenabalan @AhdraMeraliQB