Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax the upper bound on jupyter_client ⬆️ #71

Closed
wants to merge 7 commits into from
Closed

Relax the upper bound on jupyter_client ⬆️ #71

wants to merge 7 commits into from

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Mar 8, 2022 •
edited
Loading

Motivation and Context

Closes #72

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@deepyaman
Update requirements.txt
50ba1bb 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Delete requirements.txt
fd0a3d5 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update requirements.txt
bf150a2 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update requirements.txt
4730b9d 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update requirements.txt
b9581db 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman
Update requirements.txt
98a3f34 
Signed-off-by: Deepyaman Datta <deepyaman.datta@utexas.edu>
@deepyaman deepyaman marked this pull request as ready for review March 8, 2022 17:43
@deepyaman
Copy link
Member Author

FYI @datajoely

@datajoely
Copy link
Contributor

Oh you star! Thank you!

@antonymilne
Copy link
Contributor

antonymilne commented Mar 9, 2022 •
edited
Loading

Oh, I just noticed this isn't running the CI checks. Please could you do whatever you did to fix your kedro forks CircleCI issue here also? Actually we jus hadn't enabled builds on forked PRs. We've now turned this on and I've done an empty commit to trigger CI.

@lorenabalan
Copy link
Contributor

Looks like the astro-iris starter is unhappy, happy to approve once it's fixed. Also please remember to sign off every commit in order for the DCO plugin to pass (we can force it to pass but it's not sustainable in the long term). We know it's not an ideal workflow but it'a a requirements from Linux Foundation. You can have a look at https://github.com/kedro-org/kedro/blob/main/Makefile#L59-L63 for shortcut on how we enable it by default for kedro.

@lorenabalan
Copy link
Contributor

Closing this as it will be removed altogether in #78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonymilne antonymilne antonymilne approved these changes

@lorenabalan lorenabalan Awaiting requested review from lorenabalan

Assignees

@deepyaman deepyaman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relax the upper bound on jupyter_client ⬆️
4 participants
@deepyaman @datajoely @antonymilne @lorenabalan