Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically attach packaged deployment YAMLs to GitHub Release #827

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/release-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,34 @@ jobs:
run: make publish
env:
VERSION: ${{ steps.get_version.outputs.VERSION }}

# Get release information to determine id of the current release
- name: Get Release
id: get-release-info
uses: bruceadams/get-release@v1.2.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

# Upload deployment YAML files as ZIP to GitHub release
- name: Upload Deployment YAML (zip)
id: upload-deployment-yaml-zip
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: https://uploads.github.com/repos/kedacore/keda/releases/${{ steps.get-release-info.outputs.id }}/assets?name=keda-${{ steps.get_version.outputs.VERSION }}.zip
asset_path: keda-${{ steps.get_version.outputs.VERSION }}.zip
asset_name: keda-${{ steps.get_version.outputs.VERSION }}.zip
asset_content_type: application/zip

# Upload deployment YAML files as TAR to GitHub release
- name: Upload Deployment YAML (tar.gz)
id: upload-deployment-yaml-tar
uses: actions/upload-release-asset@v1
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
upload_url: https://uploads.github.com/repos/kedacore/keda/releases/${{ steps.get-release-info.outputs.id }}/assets?name=keda-${{ steps.get_version.outputs.VERSION }}.tar.gz
asset_path: keda-${{ steps.get_version.outputs.VERSION }}.tar.gz
asset_name: keda-${{ steps.get_version.outputs.VERSION }}.tar.gz
asset_content_type: application/tar+gzip
11 changes: 3 additions & 8 deletions RELEASE-PROCESS.MD
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,13 @@ The Docker Hub repo with all the different images can be seen here: https://hub.

Creating a new release in the the releases page (https://github.com/kedacore/keda/release) will trigger a GitHub workflow which will create a new image with the latest code and tagged with the next version (in this example 1.2.0) and also change the latest tag to point to this image as well.

## 4. Upload release packages

When a new GitHub release is created, upload the tar.gz and zip release package files generated during the release process.
They are named like `keda-$(VERSION).zip` and `keda-$(VERSION).tar.gz`.

## 5. Publish documentation for new version
## 4. Publish documentation for new version

Publish documentation for new version on https://keda.sh.

See [docs](https://github.com/kedacore/keda-docs#publishing-a-new-version).

## 6. Update Helm Charts
## 5. Update Helm Charts

a). Update the version and appVersion here: https://github.com/kedacore/charts/blob/master/keda/Chart.yaml
b). In the image section update the keda and metricsAdapter to point to the docker images from step 1 https://github.com/kedacore/charts/blob/master/keda/values.yaml
Expand All @@ -53,6 +48,6 @@ Update the following file:
https://github.com/Azure/azure-functions-core-tools/blob/dev/src/Azure.Functions.Cli/StaticResources/keda.yaml
[Search for 1.1.0 etc. and replace it]

## 7. Create Helm release on GitHub
## 6. Create Helm release on GitHub

Create Helm release on GitHub with changelog of what changed to our Helm chart.