Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically attach packaged deployment YAMLs to GitHub Release #827

Merged

Conversation

tomkerkhove
Copy link
Member

@tomkerkhove tomkerkhove commented May 18, 2020

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Automatically attach packaged deployment YAMLs to GitHub Release as part of our release workflow.

Checklist

  • A PR is opened to update the documentation on https://github.com/kedacore/keda-docs
  • Commits are signed with Developer Certificate of Origin (DCO)
  • Tests have been added
  • Manual test was done in separate repo (see release and workflow)
  • Update release process documentation

Fixes #764

@tomkerkhove
Copy link
Member Author

Currently, we advise triggering the process by creating a GitHub release (which creates a Git tag).

However, I'm thinking that we should maybe change this so that we just create a tag and we manage the GitHub release in the workflow as well so that we have consistent structure in our releases. Thoughts?

.github/workflows/release-build.yml Outdated Show resolved Hide resolved
.github/workflows/release-build.yml Outdated Show resolved Hide resolved
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove force-pushed the automatically-upload-release-artifacts branch from c1f57f1 to 98eff0c Compare May 25, 2020 13:21
@tomkerkhove tomkerkhove requested a review from zroubalik May 25, 2020 13:22
@tomkerkhove
Copy link
Member Author

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Tom!

@zroubalik zroubalik merged commit 0749290 into kedacore:master May 25, 2020
tbickford pushed a commit to tbickford/keda that referenced this pull request Jun 21, 2020
@tomkerkhove tomkerkhove deleted the automatically-upload-release-artifacts branch November 19, 2020 10:41
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically attach packaged deployment YAMLs to GitHub Release
3 participants