-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace $namepsace by $exported_namespace in keda-dashboard #4539
Conversation
This was solved in the chart directly: kedacore/charts@1a56c48 |
I think we should also fix this here in the core repo, not just charts. |
In that case, we should rever the change in the helm repo. It exports these metrics, if we change them here, we should change the helm chart too |
@ganievs are you willing to do this? |
Ok, will do that! |
A PR with changes in the chart repo: kedacore/charts#449 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Shamil Ganiev <ganiev@pm.me>
ccc5fdf
to
6923a4f
Compare
Signed |
@JorTurFer please confirm the chart PR is correct. |
I'm not sure I get why honorLabels needs to be removed though? |
Hi folks! In my opinion, it will be better when the dashboard will follow a default Prometheus labeling behavior because it can be used not only with the initial Keda's helm chart or requirement to enable the honor labels should be mentioned in a documentation. |
I agree with the approach of using defaults. |
When The operator and s scaled objects are deployed in different namespaces, some metrics are not shown due to namespace labels conflict.
Checklist