Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove honor label from manager service monitor #449

Merged
merged 2 commits into from
May 31, 2023
Merged

remove honor label from manager service monitor #449

merged 2 commits into from
May 31, 2023

Conversation

ganievs
Copy link
Contributor

@ganievs ganievs commented May 18, 2023 •
edited by JorTurFer
Loading

Remove a honorLabels field from the manager's service monitor due to changes in the keda-dashboard.json
Related PR: kedacore/keda#4539

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • README is updated with new configuration values (if applicable)
  • A PR is opened to update KEDA core (repo) (if applicable, ie. when deployment manifests are modified)

@ganievs ganievs requested a review from a team as a code owner May 18, 2023 09:49
@ganievs ganievs mentioned this pull request May 18, 2023
Merged
7 tasks
zroubalik
zroubalik reviewed May 18, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix DCO? https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-signing-your-work

@ganievs
remove honor label from manager service monitor
2ae5fba 
Signed-off-by: Shamil Ganiev <ganiev@pm.me>
@ganievs
Copy link
Contributor Author

ganievs commented May 18, 2023

Could you please fix DCO? https://github.com/kedacore/keda/blob/main/CONTRIBUTING.md#developer-certificate-of-origin-signing-your-work

Sure! Signed

@zroubalik zroubalik requested a review from JorTurFer May 19, 2023 09:01
JorTurFer
JorTurFer reviewed May 26, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove it from other servicemonitor/podmonitor files?

@ganievs
remove honorLabels from all podmonitor and servicemonitor kinds
e385ce8 
Signed-off-by: Shamil Ganiev <ganiev@pm.me>
@ganievs
Copy link
Contributor Author

ganievs commented May 30, 2023

Sure! Removed.

@JorTurFer JorTurFer merged commit 9eca8ff into kedacore:main May 31, 2023
@ganievs ganievs deleted the Remove-honorLabels branch May 31, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganievs @zroubalik @JorTurFer