Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support https protocol in nats scalers #3815

Merged
merged 15 commits into from
Nov 10, 2022
Merged

feat: support https protocol in nats scalers #3815

merged 15 commits into from
Nov 10, 2022

Conversation

mknet3
Copy link
Contributor

@mknet3 mknet3 commented Nov 4, 2022 •
edited by zroubalik
Loading

Signed-off-by: Manuel Cañete mcaneteubeda@gmail.com

Provide a description of what has been changed

Checklist

Fixes #3805

Relates to #

@mknet3
chore: support https protocol in nats scalers
5fa9785 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
@mknet3
change flag and add tests
1f2764f 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
@mknet3
add constants
339686e 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
@mknet3 mknet3 mentioned this pull request Nov 5, 2022
Merged
1 task
@mknet3
update changelog
5806ed9 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
@mknet3 mknet3 marked this pull request as ready for review November 5, 2022 10:38
@mknet3 mknet3 requested a review from a team as a code owner November 5, 2022 10:38
mknet3 and others added 2 commits November 5, 2022 11:38
@mknet3
Merge branch 'main' into issue-3805
98887aa 
Signed-off-by: Manuel Cañete <10815022+mknet3@users.noreply.github.com>
@mknet3
fix lint
78cd46c 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
JorTurFer
JorTurFer reviewed Nov 5, 2022
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ❤️
I left some inline comments which apply for both scalers

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/nats_jetstream_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/nats_jetstream_scaler.go Outdated Show resolved Hide resolved
mknet3 and others added 5 commits November 5, 2022 21:47
@mknet3 @JorTurFer
Update CHANGELOG.md
e1fa8e4 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Manuel Cañete <10815022+mknet3@users.noreply.github.com>
@mknet3 @JorTurFer
Update pkg/scalers/nats_jetstream_scaler.go
1775564 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Manuel Cañete <10815022+mknet3@users.noreply.github.com>
@mknet3
use pascal case in metadata
f2aa881 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
@mknet3
use pascal case in metadata
4a45996 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
@mknet3
chore: build endpoint once in the parser
5930663 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
JorTurFer
JorTurFer reviewed Nov 6, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
JorTurFer
JorTurFer reviewed Nov 6, 2022
View reviewed changes
pkg/scalers/nats_jetstream_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/stan_scaler.go Outdated Show resolved Hide resolved
@mknet3
chore: remove unnecessary variable
cdd0a7a 
Signed-off-by: Manuel Cañete <mcaneteubeda@gmail.com>
mknet3 and others added 2 commits November 7, 2022 22:18
@mknet3 @JorTurFer
Update CHANGELOG.md
d8a1468 
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Signed-off-by: Manuel Cañete <10815022+mknet3@users.noreply.github.com>
@mknet3
Merge branch 'main' into issue-3805
9ca0035
@tomkerkhove tomkerkhove changed the title chore: support https protocol in nats scalers feat: support https protocol in nats scalers Nov 8, 2022
zroubalik
zroubalik approved these changes Nov 10, 2022
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik enabled auto-merge (squash) November 10, 2022 11:45
@zroubalik
Copy link
Member

zroubalik commented Nov 10, 2022 •
edited by github-actions bot
Loading

/run-e2e nats*
Update: You can check the progress here

@zroubalik zroubalik merged commit 3b5e962 into kedacore:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support HTTPS protocol in NATS Scalers
3 participants
@mknet3 @zroubalik @JorTurFer