Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTPS protocol in NATS Scalers #3805

Closed
JorTurFer opened this issue Nov 1, 2022 · 1 comment · Fixed by #3815
Closed

Support HTTPS protocol in NATS Scalers #3805

JorTurFer opened this issue Nov 1, 2022 · 1 comment · Fixed by #3815
Assignees
@mknet3
Labels
feature-request All issues for new features that have not been committed to needs-discussion

Comments

@JorTurFer
Copy link
Member

JorTurFer commented Nov 1, 2022 •
edited
Loading

Proposal

Currently, the scalers have hardcoded the protocol (1 2), we should add an option to use https if it's needed

Use-Case

No response

Anything else?

No response
@JorTurFer JorTurFer added needs-discussion feature-request All issues for new features that have not been committed to labels Nov 1, 2022
@JorTurFer JorTurFer changed the title Support HTTPS protocol in NATS JetStream Scaler Support HTTPS protocol in NATS Scalers Nov 1, 2022
@mknet3
Copy link
Contributor

mknet3 commented Nov 3, 2022

I can do it

@zroubalik zroubalik mentioned this issue Nov 10, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknet3 mknet3

Labels
feature-request All issues for new features that have not been committed to needs-discussion
Projects
Roadmap - KEDA Core
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support https protocol in nats scalers mknet3/keda
2 participants
@mknet3 @JorTurFer