Provide branding guidelines #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
turbaszek
reviewed
Sep 9, 2020
turbaszek
reviewed
Sep 9, 2020
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
turbaszek
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Looks good but I'm not sure why the logos are not visible here: https://github.com/tomkerkhove/keda/blob/branding/BRANDING.md
|
Do you mean here? Because I see them 🤔 |
|
If you see them then ok, it can be Github issue 🤷 |
zroubalik
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
LGTM!
I got it rendered correctly here on the PR directly: https://github.com/kedacore/keda/blob/ec8a6ad8283a766b6b4794e57a97cd15ca786d21/BRANDING.md
|
Will wait for @caniszczyk for final sign-off, want to make sure it complies with CNCF standard. |
ahmelsayed
approved these changes
Sep 9, 2020
|
I'm merging this but feel free to let me know if something is not ok @caniszczyk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com
Provide branding guidelines
Checklist
Relates on #1080
Fixes #1090