Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter casing in TriggerAuthentication for Key Vault. #918

Merged
merged 1 commit into from
Aug 29, 2022

Conversation

v-shenoy
Copy link
Contributor

Signed-off-by: Vighnesh Shenoy vshenoy@microsoft.com

Provide a description of what has been changed

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO)

Fixes #877

Signed-off-by: Vighnesh Shenoy <vshenoy@microsoft.com>
@v-shenoy v-shenoy requested a review from a team as a code owner August 28, 2022 20:25
@netlify
Copy link

netlify bot commented Aug 28, 2022

Deploy Preview for keda ready!

Name Link
🔨 Latest commit 02ec834
🔍 Latest deploy log https://app.netlify.com/sites/keda/deploys/630bcf451b73c300089867c1
😎 Deploy Preview https://deploy-preview-918--keda.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@tomkerkhove tomkerkhove merged commit 506ebb4 into kedacore:main Aug 29, 2022
@v-shenoy v-shenoy deleted the kv-fix branch August 29, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs use incorrect casing for Azure KeyVault vaultUri
2 participants