Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs use incorrect casing for Azure KeyVault vaultUri #877

Closed
pinkfloydx33 opened this issue Aug 6, 2022 · 2 comments · Fixed by #918
Closed

Docs use incorrect casing for Azure KeyVault vaultUri #877

pinkfloydx33 opened this issue Aug 6, 2022 · 2 comments · Fixed by #918
Labels
bug Something isn't working

Comments

@pinkfloydx33
Copy link

The documentation for 2.7 and 2.8 uses the wrong casing for the azureKeyVault.vaultUri parameter of TriggerAuthentication/ClusterTriggerAuthentication.

The docs indicate it's vaultURI which is incorrect and does not validate during deployment. It should be vaultUri.

Interestingly, vaultURI is the name/casing of the value used in code, but as you can see it's JSON tag uses vaultUri

The CRDs also (obviously) use vaultUri:
@pinkfloydx33 pinkfloydx33 added the bug Something isn't working label Aug 6, 2022
@tomkerkhove
Copy link
Member

tomkerkhove commented Aug 8, 2022 •
edited
Loading

Thanks for reporting! Would you be open to send a PR to update the 2.7 & 2.8 docs please?

@v-shenoy
Copy link
Contributor

This was just me being dumb. 🤦🏽

@v-shenoy v-shenoy mentioned this issue Aug 28, 2022
Merged
1 task
@pinkfloydx33 pinkfloydx33 mentioned this issue Dec 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix parameter casing in TriggerAuthentication for Key Vault. v-shenoy/keda-docs
3 participants
@pinkfloydx33 @tomkerkhove @v-shenoy