Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http-add-on): Operator server uses the correct metrics port #559

Closed
wants to merge 2 commits into from
Closed

fix(http-add-on): Operator server uses the correct metrics port #559

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
403b4b4
fix(http-add-on): Operator server uses the correct metrics port
JorTurFer Nov 6, 2023
ca32aca
Merge branch 'main' into JorTurFer-patch-1
JorTurFer Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion http-add-on/templates/operator/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
ports:
- name: https
port: {{ default 8443 .Values.operator.port }}
targetPort: https
targetPort: metrics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Care to elaborate on this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, there isn't any port named https in the operator:

charts/http-add-on/templates/operator/deployment.yaml

Lines 54 to 58 in 1931630

ports:
- name: metrics
containerPort: 8080
- name: probes
containerPort: 8081

And there is one occurrence where .Value.operator.port is used:
https://github.com/kedacore/charts/blob/main/http-add-on/templates/operator/deployment.yaml#L26

That's why I supposed that the target port is the metrics port

selector:
app.kubernetes.io/component: operator
{{- include "keda-http-add-on.labels" . | indent 4 }}
Loading