fix(http-add-on): Operator server uses the correct metrics port #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
tomkerkhove
reviewed
Nov 7, 2023
| @@ -10,7 +10,7 @@ spec: | |||
| ports: | |||
| - name: https | |||
| port: {{ default 8443 .Values.operator.port }} | |||
| targetPort: https | |||
| targetPort: metrics | |||
There was a problem hiding this comment.
Sure, there isn't any port named https in the operator:
charts/http-add-on/templates/operator/deployment.yaml
Lines 54 to 58 in 1931630
And there is one occurrence where .Value.operator.port is used:
https://github.com/kedacore/charts/blob/main/http-add-on/templates/operator/deployment.yaml#L26
That's why I supposed that the target port is the metrics port
eumel8
added a commit
to eumel8/kedacharts
that referenced
this pull request
Nov 16, 2023
cherry picked kedacore#559 Signed-off-by: Frank Kloeker <f.kloeker@telekom.de>
|
Kindly reminder: PTAL @tomkerkhove xD |
|
I've included this PR on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Related to kedacore/http-add-on#812 (comment)