-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship v2.0.1 of our Helm chart #111
Conversation
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Switching to v2.1.0 since we're adding a new feature; full notes are here:
|
Charts 2.1.0 should be based on KEDA 2.1.0. If this charts release will be based on KEDA 2.0.0, how would you release chart for the upcoming KEDA 2.1.0? |
The app version of 2.1 chart is 2.0, if we would ship app 2.1, chart version would be 2.2. That's why versions are seperate in Helm, but if you want I can revert it to 2.0.1 but it's not fully semver but I'm ok with either. |
My opinion - definitely 2.0.1, Introducing 2.1 would bring too much confusion for the next releases |
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Self-approving as discussed with @zroubalik once the change is reverted |
Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com