Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship v2.0.1 of our Helm chart #111

Merged
merged 3 commits into from
Dec 23, 2020

Conversation

tomkerkhove
Copy link
Member

Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove changed the title Ship v2.0.1 of our Helm chart Ship v2.1.0 of our Helm chart Dec 22, 2020
@tomkerkhove
Copy link
Member Author

Switching to v2.1.0 since we're adding a new feature; full notes are here:

*Chart: v2.1.0 | App: v2.0.0

Minor improvements to how KEDA can be configured & use Helm v2 API version.

TL;DR

helm repo add keda https://kedacore.github.io/charts
helm install keda/keda

What is new?

Features

Fixes / Changes

Breaking Changes

None.

Removal

None.

@zroubalik
Copy link
Member

Charts 2.1.0 should be based on KEDA 2.1.0. If this charts release will be based on KEDA 2.0.0, how would you release chart for the upcoming KEDA 2.1.0?
It is bringing a lot of confusion IMHO

@tomkerkhove
Copy link
Member Author

The app version of 2.1 chart is 2.0, if we would ship app 2.1, chart version would be 2.2.

That's why versions are seperate in Helm, but if you want I can revert it to 2.0.1 but it's not fully semver but I'm ok with either.

@zroubalik
Copy link
Member

My opinion - definitely 2.0.1, Introducing 2.1 would bring too much confusion for the next releases

Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
@tomkerkhove tomkerkhove changed the title Ship v2.1.0 of our Helm chart Ship v2.0.1 of our Helm chart Dec 23, 2020
@tomkerkhove
Copy link
Member Author

Self-approving as discussed with @zroubalik once the change is reverted

@tomkerkhove tomkerkhove merged commit 38ffda3 into kedacore:master Dec 23, 2020
@tomkerkhove tomkerkhove deleted the keda-2.0.1-chart branch December 23, 2020 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants