Change Helm Chart API version to v2 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenmun197
requested review from
ahmelsayed,
jeffhollan,
tomkerkhove and
zroubalik
as code owners
Signed-off-by: Allen Mun <allen.mun@capitalone.com>
|
Thanks, this fell through the cracks unfortunately. |
tomkerkhove
approved these changes
Nov 17, 2020
tomkerkhove
changed the title
|
@zroubalik Shall we go with 2.1 for this or hold off until the other PRs are in? |
|
@tomkerkhove not sure, I'd wait some time before 2.1. so we can even release charts 2.0.1 version if it is needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue with argocd unable to install KEDA as argocd by default uses helm2 when
apiVersionis set tov1in theChart.yamlChanges
Changed
apiVersiontov2inChart.yamlto automatically default argocd to use helm3 when installing the chartReferences
https://argoproj.github.io/argo-cd/user-guide/helm/#helm-version