-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PHP 8 compatibility #72
Merged
Merged
Changes from 6 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
a4666df
Update phpcs to check for php8+
kasparsd 9eac4b0
Per linter ruleset
kasparsd 47d082f
Remove unused args
kasparsd d4a22ff
Set visibility
kasparsd b376627
Remove unused
kasparsd df2e151
Do not use native PHP names
kasparsd ef4a735
Use docker directly
kasparsd 958ca89
Mark as tested with the latest version of WP
kasparsd 761f539
Bump to a version that supports arm
kasparsd 4d4a547
Add credentials to cli containers and name them consistenty
kasparsd 814cf72
Add a helper command to interact with wp-cli
kasparsd f66b613
Add the changelog
kasparsd 1c9e565
Bump the actual version
kasparsd b74c519
Lock the WP container to PHP 7.4
kasparsd 7e1bd63
Run unit tests
kasparsd bcbcb68
npm commands are for inside Docker
kasparsd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed for PHP 8+ checks since it only lives in the
develop
.