Fix PHP 8 compatibility #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
commented
Aug 31, 2024
| @@ -2,10 +2,9 @@ | |||
|
|
|||
| class WidgetContextWordCount { | |||
|
|
|||
| private static $instance; | |||
There was a problem hiding this comment.
Wasn't referenced anywhere.
kasparsd
commented
Aug 31, 2024
| @@ -32,7 +32,7 @@ jobs: | |||
| run: npm run lint | |||
|
|
|||
| - name: Test | |||
| run: npm run test | |||
| run: composer test | |||
There was a problem hiding this comment.
The npm test script now runs things inside the Docker environment.
| "mockery/mockery": "^0.9.5", | ||
| "php-coveralls/php-coveralls": "^2.4", | ||
| "phpcompatibility/php-compatibility": "^9.3", | ||
| "phpcompatibility/php-compatibility": "dev-develop as 9.99.99", |
There was a problem hiding this comment.
Needed for PHP 8+ checks since it only lives in the develop.
| @@ -3,7 +3,7 @@ version: '3' | |||
| services: | |||
|
|
|||
| mysql: | |||
| image: mysql:5 | |||
| image: mysql:8.0 | |||
There was a problem hiding this comment.
This supports arm machines now.
| @@ -14,7 +14,7 @@ services: | |||
| MYSQL_ROOT_PASSWORD: password | |||
|
|
|||
| wordpress: | |||
| image: wordpress:latest | |||
| image: wordpress:php7.4 | |||
There was a problem hiding this comment.
Lock to a known PHP version to support phpunit tests at the current version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71.
phpcompatibility/php-compatibilityto check for PHP 8 issues.