Skip to content

fix(web): don't toast an error for the startup session-restore #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kashkoool wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web): don't toast an error for the startup session-restore #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion web/customer/src/app/core/http/error.interceptor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,17 @@ import { ProblemDetails } from '../models';
* ProblemDetails `detail`/`title` so the message is meaningful without leaking internals.
* 401s are skipped — the auth interceptor (which runs closer to the backend) silently refreshes
* and retries those, and only a truly-expired session should surface, as a redirect to login.
* The startup session-restore call (`/auth/refresh`) is also skipped: it fails by design for an
* anonymous visitor with no refresh cookie, and AuthService already handles that outcome — so a
* cold page load must never flash "Something went wrong."
*/
export const errorInterceptor: HttpInterceptorFn = (req, next) => {
const toasts = inject(ToastService);
const isSilentSessionCall = req.url.endsWith('/auth/refresh');

return next(req).pipe(
catchError((err: HttpErrorResponse) => {
if (err.status !== 401) {
if (err.status !== 401 && !isSilentSessionCall) {
toasts.error(messageFor(err));
}
return throwError(() => err);
Expand Down