Skip to content

fix(web): don't toast an error for the startup session-restore#54

Open
kashkoool wants to merge 1 commit into
mainfrom
fix/auth-refresh-silent-toast
Open

fix(web): don't toast an error for the startup session-restore#54
kashkoool wants to merge 1 commit into
mainfrom
fix/auth-refresh-silent-toast

Conversation

@kashkoool

Copy link
Copy Markdown
Owner

On a cold page load the SPA calls POST /api/auth/refresh once to restore a session from the HttpOnly refresh cookie. For an anonymous visitor (no cookie) that returns 400 by design, and AuthService.refresh() already handles it (clears state) — but the error interceptor only skipped 401s, so every anonymous load flashed "Something went wrong."

Fix: skip the toast for the silent /auth/refresh call too (it's a background session probe, not a user action). One-line change in error.interceptor.ts; ng build + ng lint clean.

On a cold load the app calls POST /api/auth/refresh once to restore a session from the
refresh cookie. For an anonymous visitor (no cookie) that returns 400 by design, and
AuthService already handles it (clears state) — but the error interceptor only skipped 401s,
so every anonymous page load flashed 'Something went wrong.' Skip the toast for the silent
/auth/refresh call too.
@coderabbitai

coderabbitai Bot commented Jun 8, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@kashkoool, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 9 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b889f4a7-d9c4-44c4-9cf5-9c36368d928f

📥 Commits

Reviewing files that changed from the base of the PR and between b2c88ea and e061229.

📒 Files selected for processing (1)
  • web/customer/src/app/core/http/error.interceptor.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/auth-refresh-silent-toast

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant