Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add new command port-forward #5464

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zhzhuang-zju
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
add new command port-forward to forward one or more local ports to a pod

Which issue(s) this PR fixes:
parts of #5249

Special notes for your reviewer:

$ karmadactl port-forward --operation-scope members service/metrics-server 443 -nkube-system --cluster member1
Forwarding from 127.0.0.1:443 -> 4443
Forwarding from [::1]:443 -> 4443

Does this PR introduce a user-facing change?:

`karmadactl`: add new command `port-forward` to forward one or more local ports to a pod

Signed-off-by: zhzhuang-zju <m17799853869@163.com>
Signed-off-by: zhzhuang-zju <m17799853869@163.com>
@karmada-bot karmada-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 30, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign chaunceyjiang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhzhuang-zju zhzhuang-zju changed the title add new command add new command port-forward Aug 30, 2024
@karmada-bot karmada-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 30, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 31.21%. Comparing base (65f686e) to head (e318322).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
pkg/karmadactl/portforward/portforward.go 0.00% 57 Missing ⚠️
pkg/karmadactl/patch/patch.go 0.00% 4 Missing ⚠️
pkg/karmadactl/karmadactl.go 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5464      +/-   ##
==========================================
- Coverage   31.25%   31.21%   -0.05%     
==========================================
  Files         642      644       +2     
  Lines       44431    44494      +63     
==========================================
  Hits        13889    13889              
- Misses      29534    29598      +64     
+ Partials     1008     1007       -1     
Flag Coverage Δ
unittests 31.21% <0.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhzhuang-zju zhzhuang-zju changed the title add new command port-forward [WIP] add new command port-forward Aug 30, 2024
@karmada-bot karmada-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants