🤖 Various enhancement to security scans #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kairos-io ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Merged
Signed-off-by: mudler <mudler@c3os.io>
Signed-off-by: mudler <mudler@c3os.io>
Signed-off-by: mudler <mudler@c3os.io>
Signed-off-by: mudler <mudler@c3os.io>
mudler
force-pushed
the
fixup/os-release
branch
from
f6d6246
to
a513dae
Compare
mudler
changed the title
mudler
commented
Mar 10, 2023
| RUN rm -rf /etc/machine-id && touch /etc/machine-id && chmod 444 /etc/machine-id | ||
|
|
||
| # Avoid to accidentally push keys generated by package managers | ||
| RUN rm -rf /etc/ssh/ssh_host_* | ||
|
|
||
| # Copy flavor-specific overlay files | ||
| IF [[ "$FLAVOR" =~ "alpine" ]] |
There was a problem hiding this comment.
this is a dup.. we already copy in the framework target the same files. It probably was an oversight when doing the framework image refactoring
|
back to business @Itxaka ! :D |
|
works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Extracted from #1093
Refactor the docker target. It is now split in base-image and image. the old docker target is equivalent to image. The base-image spits an image with an untouched os-release file so scanners can pick up the original base-image version. I've also removed some dups present in the Earthfile