🤖 Fixup trivy scans #1093
🤖 Fixup trivy scans #1093
Conversation
Signed-off-by: mudler <mudler@c3os.io>
✅ Deploy Preview for kairos-io canceled.
|
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 22.79% 23.41% +0.62%
==========================================
Files 22 22
Lines 1610 1627 +17
==========================================
+ Hits 367 381 +14
- Misses 1179 1180 +1
- Partials 64 66 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
We should probably open an issues upstream on trivy so they can fix this directly in there Edit: next time I should probably look it up before commenting aquasecurity/trivy#3811 |
|
gah, my refactor broke things 🙄 |
|
IMO, fix should go in here, refactor somewhere else so we can merge this asap |
eeeh, you are right, I was too much optimistic |
|
refactor dropped and split into #1100 |
Earthfile
Outdated
| @@ -331,23 +331,6 @@ docker: | |||
| # Avoid to accidentally push keys generated by package managers | |||
| RUN rm -rf /etc/ssh/ssh_host_* | |||
|
|
|||
| # Copy flavor-specific overlay files | |||
There was a problem hiding this comment.
this was a duplicate.. we already do that in the framework images
Earthfile
Outdated
| @@ -331,23 +331,6 @@ docker: | |||
| # Avoid to accidentally push keys generated by package managers | |||
| RUN rm -rf /etc/ssh/ssh_host_* | |||
|
|
|||
| # Copy flavor-specific overlay files | |||
There was a problem hiding this comment.
I guess this is an artifact of the split?
There was a problem hiding this comment.
nope, it actually is a dup in our Earthfile that I cought while re-walking it, moved it to the other PR
Signed-off-by: mudler <mudler@c3os.io>
It is just an attempt to see if makes it any better.
/tmp/*wasn't enough (but still good to keep it around, so we are coherent)dockertarget. It is now split inbase-imageandimage. the olddockertarget is equivalent toimage. The base-image spits an image with an untouched os-release file so scanners can pick up the original base-image version. I've also removed some dups present in the EarthfileWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1087